add task solution #1610
Open
add task solution #1610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiserett
suggested changes
Aug 22, 2023
src/components/Person/Person.jsx
Outdated
Comment on lines
18
to
20
| {age && ( | ||
| <p className="Person__age">{`I am ${age}`}</p> | ||
| )} |
There was a problem hiding this comment.
I guess if age is gonna be 0 it's not gonna work correctly, I mean age 0 is not correctly itself, but react will probably just render '0' on the page, so we have to convert it to boolean to make sure it works just fine, we can achieve it by using !! or Boolean
src/components/Person/Person.jsx
Outdated
Comment on lines
22
to
30
| {isMarried ? ( | ||
| <p className="Person__partner"> | ||
| {`${partnerName} is my ${sex === SEX_MALE | ||
| ? 'wife' | ||
| : 'husband'}`} | ||
| </p> | ||
| ) : ( | ||
| <p className="Person__partner">I am not married</p> | ||
| )} |
There was a problem hiding this comment.
let's write ternary inside of
tag
- let's create variable to get rid of inner ternary
Anna-Tkachenko
requested changes
Aug 22, 2023
src/components/Person/Person.jsx
Outdated
Comment on lines
22
to
26
| {age | ||
| ? ( | ||
| <p className="Person__age">{`I am ${age}`}</p> | ||
| ) | ||
| : null} |
There was a problem hiding this comment.
Will be better to use Boolean() check and use && operator instead of ternary one
src/components/Person/Person.jsx
Outdated
| : null} | ||
|
|
||
| {isMarried ? ( | ||
| <p className="Person__partner"> |
There was a problem hiding this comment.
The outer paragraph is the same for both cases
Don't repeat yourself
Let's change only the paragraph content depending on the variable value
roman-mirzoian
approved these changes
Aug 23, 2023
Comment on lines
+28
to
+32
| <p className="Person__partner"> | ||
| {isMarried | ||
| ? messageAboutPartner | ||
| : messageAboutFreedom} | ||
| </p> |
There was a problem hiding this comment.
Suggested change
| <p className="Person__partner"> | |
| {isMarried | |
| ? messageAboutPartner | |
| : messageAboutFreedom} | |
| </p> | |
| <p className="Person__partner"> | |
| {isMarried | |
| ? messageAboutPartner | |
| : messageAboutFreedom | |
| } | |
| </p> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK