add task solution #1608
Open
add task solution #1608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 22, 2023 14:36
Anna-Tkachenko
requested changes
Aug 22, 2023
src/components/Person/Person.jsx
Outdated
| // export const Person = ({ person }) => (); | ||
| export const Person = ({ person }) => { | ||
| const { name, age, sex, isMarried, partnerName } = person; | ||
| const sexPartner = sex === 'm' ? 'wife' : 'husband'; |
There was a problem hiding this comment.
Suggested change
| const sexPartner = sex === 'm' ? 'wife' : 'husband'; | |
| const sexPartner = sex === 'm' | |
| ? 'wife' | |
| : 'husband'; |
src/components/Person/Person.jsx
Outdated
|
|
||
| return ( | ||
| <section className="Person"> | ||
| <h2 className="Person__name">{`My name is ${name}`}</h2> |
There was a problem hiding this comment.
Suggested change
| <h2 className="Person__name">{`My name is ${name}`}</h2> | |
| <h2 className="Person__name"> | |
| {`My name is ${name}`} | |
| </h2> |
src/components/Person/Person.jsx
Outdated
| return ( | ||
| <section className="Person"> | ||
| <h2 className="Person__name">{`My name is ${name}`}</h2> | ||
| {age && <p className="Person__age">{`I am ${age}`}</p>} |
There was a problem hiding this comment.
Suggested change
| {age && <p className="Person__age">{`I am ${age}`}</p>} | |
| {age && ( | |
| <p className="Person__age"> | |
| {`I am ${age}`} | |
| </p> | |
| )} |
src/components/Person/Person.jsx
Outdated
| {age && <p className="Person__age">{`I am ${age}`}</p>} | ||
| {isMarried | ||
| ? ( | ||
| <p className="Person__partner">{`${partnerName} is my ${sexPartner}`}</p> |
There was a problem hiding this comment.
Don't repeat yourself: the outer paragraph is the same for both cases
Change just the content depending on the variable value
Moroz-Dmytro
approved these changes
Aug 23, 2023
Comment on lines
+12
to
+13
| </h2> | ||
| {age && ( |
There was a problem hiding this comment.
Suggested change
| </h2> | |
| {age && ( | |
| </h2> | |
| {Boolean(age) && ( |
Comment on lines
+17
to
+21
| )} | ||
| <p className="Person__partner"> | ||
| {isMarried | ||
| ? `${partnerName} is my ${sexPartner}` | ||
| : 'I am not married'} |
There was a problem hiding this comment.
Suggested change
| )} | |
| <p className="Person__partner"> | |
| {isMarried | |
| ? `${partnerName} is my ${sexPartner}` | |
| : 'I am not married'} | |
| )} | |
| <p className="Person__partner"> | |
| {isMarried | |
| ? `${partnerName} is my ${sexPartner}` | |
| : 'I am not married' | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK