Develop #1590
Open
Develop #1590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anastasiia-tilikina
suggested changes
Aug 21, 2023
src/App.jsx
Outdated
Comment on lines
30
to
32
| <Person | ||
| person={misha} | ||
| /> |
There was a problem hiding this comment.
Suggested change
| <Person | |
| person={misha} | |
| /> | |
| <Personperson={misha} /> |
src/components/Person/Person.jsx
Outdated
Comment on lines
14
to
16
| {person.isMarried === true ? ( | ||
| newVariable | ||
| ) : (`I am not married`)} |
There was a problem hiding this comment.
Suggested change
| {person.isMarried === true ? ( | |
| newVariable | |
| ) : (`I am not married`)} | |
| {person.isMarried | |
| ? newVariable | |
| : `I am not married` | |
| } |
src/components/Person/Person.jsx
Outdated
| @@ -1 +1,20 @@ | |||
| // export const Person = ({ person }) => (); | |||
| export const Person = ({ person }) => { | |||
| const newVariable = person.sex === 'm' ? ( | |||
There was a problem hiding this comment.
It is not a mistake but in the future try to use more descriptive vars names. for instance, here it could be partnersInfo or something. It is a good practice
lerastarynets
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK