add task solution #1589
Open
add task solution #1589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moroz-Dmytro
suggested changes
Aug 22, 2023
src/components/Person/Person.jsx
Outdated
Comment on lines
7
to
17
| if (sex === SEX_FEMALE) { | ||
| return ( | ||
| <p className="Person__partner">{`${partnerName} is my husband`}</p> | ||
| ); | ||
| } | ||
|
|
||
| if (sex === SEX_MALE) { | ||
| return ( | ||
| <p className="Person__partner">{`${partnerName} is my wife`}</p> | ||
| ); | ||
| } |
There was a problem hiding this comment.
Maybe we can simplify this. The only difference between these 2 returns is the partner wife or husband. So better to use ternary here
src/components/Person/Person.jsx
Outdated
| <section className="Person"> | ||
| <h2 className="Person__name">{`My name is ${name}`}</h2> | ||
|
|
||
| {typeof age === 'number' && ( |
There was a problem hiding this comment.
Suggested change
| {typeof age === 'number' && ( | |
| {!!age && ( |
polosanya
approved these changes
Aug 22, 2023
Comment on lines
+26
to
+28
| { isMarried | ||
| ? (<p className="Person__partner">{`${partnerName} is my ${getPartnerStatus(sex)}`}</p>) | ||
| : (<p className="Person__partner">I am not married</p>) |
There was a problem hiding this comment.
You can put this condition inside "Person__partner" element, as it's used in both cases
| <section className="Person"> | ||
| <h2 className="Person__name">{`My name is ${name}`}</h2> | ||
|
|
||
| {!!age && ( |
There was a problem hiding this comment.
It's not critical, but would be great to check if the age is a positive number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK