Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved task #1584

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Solved task #1584

wants to merge 4 commits into from

Conversation

AndriiKuz
Copy link

src/components/Person/Person.jsx Outdated Show resolved Hide resolved
src/components/Person/Person.jsx Outdated Show resolved Hide resolved
src/components/Person/Person.jsx Outdated Show resolved Hide resolved
src/components/Person/Person.jsx Outdated Show resolved Hide resolved
src/components/Person/Person.jsx Outdated Show resolved Hide resolved
src/components/Person/Person.jsx Outdated Show resolved Hide resolved
Copy link

@roman-mirzoian roman-mirzoian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, but there is quite a bit of work to be done.

src/components/Person/Person.jsx Outdated Show resolved Hide resolved
src/components/Person/Person.jsx Outdated Show resolved Hide resolved
Copy link

@mr-olesha mr-olesha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!

Copy link

@Moroz-Dmytro Moroz-Dmytro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ 👍
Small advice about naming

isMarried,
} = person;

const merriageStatusInfo = sex === MALE ? WIFE : HUSBAND;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const merriageStatusInfo = sex === MALE ? WIFE : HUSBAND;
const partnerMarriageStatus = sex === MALE
? WIFE
: HUSBAND;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants