Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solution #1580

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

solution #1580

wants to merge 2 commits into from

Conversation

Sancz0pansa
Copy link

choeqq
choeqq suggested changes Aug 22, 2023
View reviewed changes
src/components/Person/Person.jsx
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try not to use {' '}

README.md
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your GH pages ain't working :(

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idk what i can do about it

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably you need to redeploy it 😬

choeqq
choeqq suggested changes Aug 23, 2023
View reviewed changes
Copy link

@choeqq choeqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but please try to make your GH pages work 😄

choeqq
choeqq approved these changes Aug 23, 2023
View reviewed changes
Copy link

@choeqq choeqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choeqq choeqq choeqq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sancz0pansa @choeqq