Add task solution #1578
Open
Add task solution #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiserett
suggested changes
Aug 22, 2023
src/App.jsx
Outdated
Comment on lines
33
to
36
| {/* <section className="Person"> | ||
| <h2 className="Person__name">My name is Olya</h2> | ||
| <p className="Person__partner">Maksym is my husband</p> | ||
| </section> |
src/components/Person/Person.jsx
Outdated
Comment on lines
1
to
10
| export const Person = ({ person }) => ( | ||
| <section className="Person"> | ||
| <h2 className="Person__name">{`My name is ${person.name}`}</h2> | ||
| {person.age && <p className="Person__age">{`I am ${person.age}`}</p>} | ||
| <p className="Person__partner"> | ||
| {person.isMarried | ||
| ? (`${person.partnerName} is my ${person.sex === 'm' ? 'wife' : 'husband'}`) | ||
| : (`I am not married`)} | ||
| </p> | ||
| </section> |
There was a problem hiding this comment.
use destructuring + fix code style, add some spaces, put properties on the new line + get rid of ternary inside of ternary, create variable for it
|
fix demo link please |
Moroz-Dmytro
suggested changes
Aug 23, 2023
src/components/Person/Person.jsx
Outdated
| partnerName, | ||
| sex, | ||
| } = person; | ||
| const partnerSex = sex === 'm' ? 'wife' : 'husband'; |
src/components/Person/Person.jsx
Outdated
Comment on lines
15
to
16
| </h2> | ||
| {age && ( |
There was a problem hiding this comment.
Suggested change
| </h2> | |
| {age && ( | |
| </h2> | |
| {Boolean(age) && ( |
src/components/Person/Person.jsx
Outdated
Comment on lines
16
to
20
| {age && ( | ||
| <p className="Person__age"> | ||
| {`I am ${age}`} | ||
| </p> | ||
| )} |
There was a problem hiding this comment.
Suggested change
| {age && ( | |
| <p className="Person__age"> | |
| {`I am ${age}`} | |
| </p> | |
| )} | |
| {age && ( | |
| <p className="Person__age"> | |
| {`I am ${age}`} | |
| </p> | |
| )} |
src/components/Person/Person.jsx
Outdated
Comment on lines
22
to
24
| {isMarried | ||
| ? (`${partnerName} is my ${partnerSex}`) | ||
| : (`I am not married`)} |
There was a problem hiding this comment.
Suggested change
| {isMarried | |
| ? (`${partnerName} is my ${partnerSex}`) | |
| : (`I am not married`)} | |
| {isMarried | |
| ? `${partnerName} is my ${partnerSex}` | |
| : 'I am not married' | |
| } |
src/components/Person/Person.jsx
Outdated
| partnerName, | ||
| sex, | ||
| } = person; | ||
| const partnerSex = sex === 'm' ? 'wife' : 'husband'; |
There was a problem hiding this comment.
Suggested change
| const partnerSex = sex === 'm' ? 'wife' : 'husband'; | |
| const parterMarriageStatus = sex === 'm' ? 'wife' : 'husband'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://davinnchii.github.io/react_person/