Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react person #1559

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

react person #1559

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
256493c
react person
alina-isakova Aug 14, 2023
3bb5268
react person with destructing & variable
alina-isakova Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 10 additions & 14 deletions src/App.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import React from 'react';
import './App.scss';
import { Person } from './components/Person/Person';

export const misha = {
name: 'Misha',
Expand All @@ -25,21 +26,16 @@ export const alex = {

export const App = () => (
<div className="App">
<section className="Person">
<h2 className="Person__name">My name is Misha</h2>
<p className="Person__age">I am 37</p>
<p className="Person__partner">Natasha is my wife</p>
</section>
<Person
person={misha}
/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no needs to write from a new line since you have only one prop.
Apply for other cases below

Suggested change
<Person
person={misha}
/>
<Person person={misha} />


<section className="Person">
<h2 className="Person__name">My name is Olya</h2>
<p className="Person__partner">Maksym is my husband</p>
</section>
<Person
person={olya}
/>

<section className="Person">
<h2 className="Person__name">My name is Alex</h2>
<p className="Person__age">I am 25</p>
<p className="Person__partner">I am not married</p>
</section>
<Person
person={alex}
/>
</div>
);
24 changes: 23 additions & 1 deletion src/components/Person/Person.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,23 @@
// export const Person = ({ person }) => ();
export const Person = ({ person }) => (
<section className="Person">
<>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a good practice to use object destructing

Suggested change
export const Person = ({ person }) => (
<section className="Person">
export const Person = ({ person }) => {
const {...} = person
return (
<section className="Person">

<h2 className="Person__name">
{`My name is ${person.name}`}
</h2>

{person.age && (
<p className="Person__age">
{`I am ${person.age}`}
</p>
)}

<p className="Person__partner">
{person.isMarried === true ? (
`${person.partnerName} is my ${person.sex === 'm' ? 'wife' : 'husband'}`
) : (
'I am not married'
)}
</p>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. move this conditions to a variable to increase readability
  2. person.isMarried === true ? is the same as just person.isMarried ?

</>
</section>
);
Loading