Develop #1523
Open
Develop #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anastasiia-Svintsova
suggested changes
Aug 2, 2023
src/App.jsx
Outdated
Comment on lines
7
to
9
| <Person | ||
| person={misha} | ||
| /> |
There was a problem hiding this comment.
There is no need to split it into several lines when there are fewer than 3 props
Suggested change
| <Person | |
| person={misha} | |
| /> | |
| <Person person={misha} /> |
src/Person.jsx
Outdated
Comment on lines
10
to
12
| My name is | ||
| {' '} | ||
| {name} |
There was a problem hiding this comment.
Consider using Template literals for better readability
src/Person.jsx
Outdated
Comment on lines
14
to
15
| <p className="Person__age"> | ||
| {age && ( |
There was a problem hiding this comment.
Don't render this element if there is no age
Suggested change
| <p className="Person__age"> | |
| {age && ( | |
| {age && ( | |
| <p className="Person__age"> |
src/Person.jsx
Outdated
Comment on lines
4
to
5
| const { name, age, sex, isMarried, | ||
| partnerName = 'I am not married' } = person; |
There was a problem hiding this comment.
The partnerName should be a name. You can create a separate variable for a partner and assign a value here
Suggested change
| const { name, age, sex, isMarried, | |
| partnerName = 'I am not married' } = person; | |
| const { | |
| name, | |
| age, | |
| sex, | |
| isMarried, | |
| partnerName | |
| } = person; |
lerastarynets
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://Hanna-Balabukha.github.io/react_person/