Added base test #254
Merged
Added base test #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alexandra-protyanova
commented
Jan 18, 2024
•
alexandra-protyanova
commented
alexandra-protyanova
requested review from
mgrinko and
sergii-nosachenko
and removed request for
mgrinko and
sergii-nosachenko
mgrinko
approved these changes
Jan 23, 2024
Comment on lines
+13
to
+21
| const baseCommand = 'node src/app.js'; | ||
| let sourceContent = ''; | ||
| const tempDir = path.join('tests', faker.word.noun()); | ||
|
|
||
| const sourceFile = path.join(tempDir, faker.system.commonFileName('txt')); | ||
| const destinationFile = path.join( | ||
| tempDir, | ||
| faker.system.commonFileName('txt'), | ||
| ); |
There was a problem hiding this comment.
What's the reason to have some constants inside the describe but the other's outside?
There was a problem hiding this comment.
I based on the imports system which should be out of describe, but I read that it is commonly good practise to store requires out of describe
| fs.rmdirSync(tempDir, { recursive: true }); | ||
| }); | ||
|
|
||
| test('should throw an error if only one argument is provided', async() => { |
There was a problem hiding this comment.
Students will start from success story
So it is more logical to test success flow first
tests/copyFiles.test.js
Outdated
| test('should copy file to a new destination overwriting existing content', async() => { | ||
| const differentContent = faker.lorem.paragraph(); | ||
|
|
||
| fs.writeFileSync(destinationFile, differentContent); |
There was a problem hiding this comment.
We use the same file all the time
What if prew tests block it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.