Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #1774

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Develop #1774

wants to merge 6 commits into from

Conversation

pogorielova
Copy link

BudnikOleksii
BudnikOleksii suggested changes Oct 28, 2024
View reviewed changes
Copy link

@BudnikOleksii BudnikOleksii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 👍
A few moments that should be fixed:

  • When a user hovers over the phone icon you should show the number
    image

  • The content in the footer and in other sections should have the same max-width
    image

  • All interactive elements such as buttons should have a cursor pointer

  • I'm not sure about increasing buttons on hover, they looks too big, but it's up to you

StasSokolov1
StasSokolov1 suggested changes Oct 31, 2024
View reviewed changes
Copy link

@StasSokolov1 StasSokolov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, a few comments left to fix before approval!

  1. User can resize textarea like this, need to restrict this possibility
Screenshot 2024-10-31 at 11 38 25
  1. Let's add cursor pointer for recommended section
Screenshot 2024-10-31 at 11 38 15

BudnikOleksii
BudnikOleksii approved these changes Oct 31, 2024
View reviewed changes
Copy link

@BudnikOleksii BudnikOleksii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BudnikOleksii BudnikOleksii BudnikOleksii approved these changes

@StasSokolov1 StasSokolov1 Awaiting requested review from StasSokolov1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pogorielova @BudnikOleksii @StasSokolov1