hw added #672
Open
hw added #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliceblunt8
suggested changes
Mar 23, 2021
src/style.css
Outdated
| } | ||
|
|
||
| .block-blue { | ||
| width: 328px; |
There was a problem hiding this comment.
width should be set to 350px, not 328px
There was a problem hiding this comment.
use box-sizing css rule for this task
src/style.css
Outdated
Comment on lines
26
to
28
| .mid { | ||
| margin: 40px 20px; | ||
| } |
There was a problem hiding this comment.
instead of adding separate class with margins mb add margin: 20px to body and margin-bottom: 40px to each block?
aliceblunt8
suggested changes
Mar 23, 2021
src/style.css
Outdated
| @@ -0,0 +1,28 @@ | |||
| * { | |||
| box-sizing: border-box; | |||
| background-color: #000; | |||
There was a problem hiding this comment.
add background-color: #000 to body, not to ALL elements on the page
aliceblunt8
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK
TEST REPORT LINK