add task solution calendar #3892
Conversation
internal77
commented
Oct 22, 2024
internal77
commented
- DEMO LINK
- TEST REPORT LINK
There was a problem hiding this comment.
Great job on implementing the loops correctly! 🎉 Just make sure the default month length is set to 31 days and the start day to Sunday, as per the task requirements. Also, double-check your build process to ensure SCSS is compiled to CSS. Keep up the good work!
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| @@ -9,10 +9,44 @@ | |||
| <title>Calendar</title> | |||
| <link | |||
| rel="stylesheet" | |||
| href="styles/index.scss" | |||
| href="styles/main.scss" | |||
There was a problem hiding this comment.
The stylesheet link is pointing to a SCSS file (styles/main.scss). Ensure that your build process (e.g., using Parcel) correctly compiles SCSS to CSS, as browsers do not natively support SCSS files.
| } | ||
|
|
||
| @each $day, $index in $start-day { | ||
| &.calendar--start-day-#{$day} { |
There was a problem hiding this comment.
The @each loop correctly creates modifiers for the calendar class based on the start-day variable. However, ensure that the default start day is set to Sunday, as specified in the task description.
| } | ||
|
|
||
| @for $i from 28 through 31 { | ||
| &.calendar--month-length-#{$i} { |
There was a problem hiding this comment.
The @for loop for the month-length modifier is implemented correctly. Ensure that the default month length is set to 31 days, as required by the task description.
