Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Museum DONE #570

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

IrynaMariiko00
Copy link

Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.

Needs some improvements with form.
Nothing happened after click on button (form should reset and not reload page)
Actually it is not a button)
Screenshot 2024-09-21 at 10 07 59

  • make element as button with type submit (it is default type for buttons). add cursor pointer and some hover effect.

Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done.
The page shouldn't be reloaded on form submit, but the fields should be cleared. Use:

<form onsubmit="this.reset(); return false;">

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done!
To improve:

  1. Need to remove scroll when the menu is open
image
  1. Change the autofill styles for the form fields
    https://css-tricks.com/snippets/css/change-autocomplete-styles-webkit-browsers/
image
  1. Add hover effects for all clickable elements on the page
image
  1. Fix this bug with text
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants