Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

museum was created #561

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

museum was created #561

wants to merge 6 commits into from

Conversation

vlad-ptashnichenko
Copy link

TarasHoliuk
TarasHoliuk suggested changes Aug 14, 2024
View reviewed changes
Copy link

@TarasHoliuk TarasHoliuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your demo link doesn't work:

image

Please, fix it and then re-request review. If you need help with it - feel free to ask in the chat

@TarasHoliuk
Copy link

TarasHoliuk commented Aug 14, 2024 •
edited
Loading

UPD: do not close your Pull-Request
Open it again, please

@TarasHoliuk
Copy link

  1. Open external links in the new tab:

image

  1. Missing images:
    image

TarasHoliuk
TarasHoliuk suggested changes Aug 14, 2024
View reviewed changes
Copy link

@TarasHoliuk TarasHoliuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 2 fixes are required 🙂

etojeDenys
etojeDenys suggested changes Aug 15, 2024
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't open the new page on number click
image

  1. looks different
image image
  1. wrong background color
image image

VitaliyBondarenko1982
VitaliyBondarenko1982 approved these changes Aug 19, 2024
View reviewed changes
Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VitaliyBondarenko1982 VitaliyBondarenko1982 VitaliyBondarenko1982 approved these changes

@TarasHoliuk TarasHoliuk Awaiting requested review from TarasHoliuk

@etojeDenys etojeDenys Awaiting requested review from etojeDenys

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vlad-ptashnichenko @TarasHoliuk @VitaliyBondarenko1982 @etojeDenys