Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAMU museum #558

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

NAMU museum #558

wants to merge 5 commits into from

Conversation

ly-manka
Copy link

@ly-manka ly-manka commented Aug 9, 2024

etojeDenys
etojeDenys suggested changes Aug 10, 2024
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image we don't have it in the mockup, pls fix it

volodymyr-soltys97
volodymyr-soltys97 suggested changes Aug 12, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
To improve:

  1. Add a favicon on the page
image
  1. Add transition when the burger menu appears on the page and remove scroll when menu is open
image
  1. Keep going with the next sections

anastasiiavorobiova
anastasiiavorobiova suggested changes Aug 15, 2024
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Screenshot 2024-08-15 at 17 51 46
Consider using links here

@ly-manka ly-manka changed the title implement header and burger-menu NAMU museum Aug 16, 2024
volodymyr-soltys97
volodymyr-soltys97 approved these changes Aug 16, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volodymyr-soltys97 volodymyr-soltys97 volodymyr-soltys97 approved these changes

@etojeDenys etojeDenys Awaiting requested review from etojeDenys

@anastasiiavorobiova anastasiiavorobiova Awaiting requested review from anastasiiavorobiova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ly-manka @volodymyr-soltys97 @etojeDenys @anastasiiavorobiova