Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #556

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

svitlanak31
Copy link

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your page

  1. Fix background color for this button and add cursor pointer here
image
  1. Сhange the autofill styles for the form fields
    https://css-tricks.com/snippets/css/change-autocomplete-styles-webkit-browsers/
image
  1. You need to reset form field after submitting form
image
  1. Add cursor pointer for all clickable elements on the page
image
  1. Add hover effects here
image
  1. Add actual links for these social networks and open it in the new tab
image

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done!
To improve:

  1. The autofill styles must be are same as default styles. Also, remove a default blue border when input is focused
image image
  1. Remove yourprofile from these links
image

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Make sure to fix linter errors
Screenshot 2024-08-05 at 15 38 35
The menu looks a bit broken in the landscape mode
Screenshot 2024-08-05 at 15 40 20

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants