fix: adds lookup_keys for cisa_kev enrichment table #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rileydakota <[email protected]>
|
Assuming my assumption above is correct, looks like the other managed enrichment tables need their lookup keys specified too? I'd be happy to include those in this PR if appropriate |
|
Great, I'll do a quick check, we may not be merging these in when using a managed enrichment table right now, should add that for convenience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on https://www.matano.dev/docs/enrichment/lookup-data - it looks like
lookup_keysneeds to be specified in order to be able to lookup against the enrichment table in our python rules and VRL. Adding this to the managed enrichment definition forcisa_kev