-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the moz-box #38
Open
pimmink
wants to merge
40
commits into
compass
Choose a base branch
from
master
base: compass
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add the moz-box #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes the "justify" property for Legacy and Microsoft flexbox syntax.
flex-grow for old webkit syntax (Android Browser)
Add fallback for justify-content(space-between)
Changes: 1. SCSS test file. 2. Added `.sass-cache*` to `.gitignore`. 3. Added mixin default args. 4. Cleaned up comments (wrapping to 72 characters). 5. Added property descriptions. 6. Added link to W3.org docs. 7. Slighty modified logic for a few `@if ...` directives.
Mixin defaults ...
Changing flexbox and inline-flex from a mixin to a class should produce less CSS when compiled.
Using @extend rather than calling a mixin.
Updated to produce less CSS when compiled
Revert to mixins, but add placeholders too.
Fixed the reference url for flex-basis
… value for -webkit-box-flex. Fixes #10.
Check if the argument passed to flex() is a list and return the right value. Fixes #10.
So the previous pull request #11 was actually broken. The output of `@mixin flex()` when given a list wasn't filling out all the properties correctly. This PR should fix that, and ensure that all box-flex properties are filled out appropriately too! Now both, for example, `@include flex(10, 5, 100px)` and `@include flex(10 5 100px)` work!
Update @mixin flex() to accomodate box-flex
IE10 uses the (as far as I could find) undocumented -ms-flex-pack: distribute; for the space-around value. Could find no similar implementation of the old flexbox spec by other vendors.
justify-content: space-around IE10 fix
Note: You will have to make a tag/release that matches the version number in this bower.json file. For discussion, see #17.
Added bower.json file.
Add package.json for publication on NPM
added quotes to license MIT
added quotes to license MIT
get master merges
Fixes #24
Compatibility with [npm-sass](https://github.com/lennym/npm-sass)
Added `sass` field to package.json
Added bower installation guide
+ keywords
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mixin is great! But you forgot the moz-box.
And -ms-flex-wrap is nowrap not none