Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

메인 페이지 리팩토링 #81

Merged
merged 3 commits into from
Mar 14, 2022
Merged

메인 페이지 리팩토링 #81

merged 3 commits into from
Mar 14, 2022

Conversation

Baek2back
Copy link
Member

변경사항

  • react-lottie가 더 이상 maintain 되지 않아 링크 lottie-web을 직접 사용하도록 변경해주었습니다.
  • 기존에 svg를 사용하던 부분을 lottie를 사용하도록 변경하고 디자인 변경에 대응하였습니다.

작업 유형

  • 리팩토링
  • 패키지 추가 및 버전 변경

체크리스트

  • Merge 할 브랜치가 올바른가?
  • 코딩컨벤션을 준수하였는가?
  • 해당 PR과 관련없는 변경사항이 없는가? (만약 있다면 제목이나 변경사항에 기술하여 주세요.)
  • 실행시 console 창에 에러나 경고가 없는것을 확인하였는가? (개발에 필요하여 고의적으로 남겨둔것 제외)

@Baek2back Baek2back self-assigned this Mar 14, 2022
HaJunRyu
HaJunRyu approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@HaJunRyu HaJunRyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Baek2back Baek2back merged commit 4df671e into develop Mar 14, 2022
@Baek2back Baek2back deleted the refactor/main-page branch March 14, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaJunRyu HaJunRyu HaJunRyu approved these changes

@mango906 mango906 Awaiting requested review from mango906

@dididy dididy Awaiting requested review from dididy

@minsour minsour Awaiting requested review from minsour

Assignees

@Baek2back Baek2back

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Baek2back @HaJunRyu