Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

English to Nzema #120

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

English to Nzema #120

wants to merge 13 commits into from

Conversation

salomeyosei
Copy link
Contributor

Salomey English to Nzema

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

Copy link
Contributor

@espoirMur espoirMur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@salomeyosei , This is very awesome, keep up the good work.

  • Few point :
  • can you please update the PR description or the readme to tell us more about the Nzema language? (Where it's spoken, how many people speaks it, for example)
  • I saw that you add many starter notebooks, are they related to this language?

@salomeyosei
Copy link
Contributor Author

@salomeyosei , This is very awesome, keep up the good work.

* Few point :

* can you please update the PR description or the readme to tell us more about the Nzema language? (Where it's spoken, how many people speaks it, for example)

* I saw that you add many starter notebooks, are they related to this language?

Those must be languages that i tried to train.

The Nzema are an Akan people numbering about 328,700, of whom 262,000 live in southwestern Ghana and 66,700 live in the southeast of Côte d'Ivoire. In Ghana the Nzema area is divided into three electoral districts of Nzema East Municipal also referred to as Evalue Gwira, Ellembele District and Nzema West, which is also referred to as Jomoro District of Ghana. Their language is also known as Nzima (in Ghana) or Appolo (in the Ivory Coast). From Wikepedia.

@salomeyosei
Copy link
Contributor Author

@salomeyosei , This is very awesome, keep up the good work.

* Few point :

* can you please update the PR description or the readme to tell us more about the Nzema language? (Where it's spoken, how many people speaks it, for example)

* I saw that you add many starter notebooks, are they related to this language?

Those must be languages that i tried to train.

The Nzema are an Akan people numbering about 328,700, of whom 262,000 live in southwestern Ghana and 66,700 live in the southeast of Côte d'Ivoire. In Ghana the Nzema area is divided into three electoral districts of Nzema East Municipal also referred to as Evalue Gwira, Ellembele District and Nzema West, which is also referred to as Jomoro District of Ghana. Their language is also known as Nzima (in Ghana) or Appolo (in the Ivory Coast). From Wikepedia.

Read me file has been edited.

Copy link
Member

@jaderabbit jaderabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @salomeyosei

Thank you very much for submitting a benchmark!

One thing from my side: the folder name should use the ISO language code.
The one for nzema is nzi
Would you change the folder name to en-nzi?

@@ -0,0 +1,725 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the above, it looks like you haven't updated it to train for nzi! This is training one for xh i.e. isiXhosa

Is this the correct notebook?


Reply via ReviewNB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think i lost the main notebook...I don't know how but am still searching for it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The notebook is wrong
Just confirmed. If i can't find it then i need to retrain

@juliakreutzer
Copy link
Collaborator

Looks good! Great work, @salomeyosei! 💯

As far as I can tell, the only thing that needs to get fixed are the additional notebooks not under the benchmarks directory.
Could you please remove them from the pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants