Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: don't run website deployment on forks #4734

Merged

Conversation

senekor
Copy link
Collaborator

@senekor senekor commented Oct 30, 2024

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

I have manually tested this change on my own fork confirming that the job doesn't run. If I replace "martinvonz" with "senekor", it runs again (but obviously failing), so it should continue to run on the main repo.

Copy link
Owner

@martinvonz martinvonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@senekor
Copy link
Collaborator Author

senekor commented Nov 1, 2024

The PR description template says "Merge the PR at will once it's been approved.", but I can't do that. GitHub UI says "Only those with write access to this repository can merge pull requests."

@martinvonz
Copy link
Owner

The PR description template says "Merge the PR at will once it's been approved.", but I can't do that.

Ah, sorry, I thought you already were a collaborator. I've invited you now.

@martinvonz martinvonz merged commit 91f869c into martinvonz:main Nov 1, 2024
18 checks passed
@senekor senekor deleted the remo/dont-deploy-website-on-forks branch November 1, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants