templates: add .email_domain()
method to Signature
s
#4687
+24
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is slightly less pretty than making an Email type, but I think is much easier.
I would use instead of the last argument of:
(Aside for more motivation: I initially had a bug above by using
.remove_prefix(signature.username() ++ "@")
. This is wrong since an email might not contain an@
, as I discovered while looking at the code. The bug is now fixed, butsignature.email_domain()
would avoid the problem)The effect I was going for (though I'm still not sure whether and how many characters I want to trim to):
Checklist
If applicable:
CHANGELOG.md