lib: Supporting building for wasm32-wasip1
#4519
Conversation
|
Can you please adjust the commit message to |
Earthmark
force-pushed
the
earthmark/lib-wasi@origin
branch
from
805ae84
to
ed154fa
Compare
|
Oh something went wrong, all the files in the project got modified. I think they got mangled newline wise (my dev setup is a bit strange) |
There was a problem hiding this comment.
Seems fine, but let's add a build matrix entry too. I suspect we'll probably need to remove git support for that to work? I would be surprised if libgit2 and the needed deps all build cleanly.
If we could actually build the CLI without git support, we would in theory throw away most of the external deps, and be able to write a WASI backend that used the browser filesystem APIs. Then we could host a version of JJ in the browser as an interactive tutorial. :)
Earthmark
force-pushed
the
earthmark/lib-wasi@origin
branch
from
ed154fa
to
b5abb8d
Compare
Earthmark
changed the title
lib building for wasm32-wasip1wasm32-wasip1
Step added, it should verify |
|
This should probably wait until #4478 goes through, I feel that change is likely a higher precedence and it'd be easy to rebuild these changes. |
Commit message adjusted. The use case for this is building out very trivial vfs-wasi support to https://github.com/RobertBaruch/dergwasm to represent entities in the game world as entries in a filesystem, and running jj as a wasm executable to version objects inside the VR environment, from inside the environment itself. @thoughtpolice 's use case of a web tool on an example filesystem is a much more realizeable use case. I said this in another comment, but I feel #4478 should probably go through first, as it's a much more complex change. |
Earthmark
force-pushed
the
earthmark/lib-wasi@origin
branch
from
b5abb8d
to
13102f1
Compare
|
Turns out the executable bit of every file got set on accident. My main machine is windows, but I worked on this repo in a linux dev container with the folder mounted into the container. I'm pretty sure it exposes mounted windows files as 755, which got committed to the repo by the dev container. In my initial change I ran jj from the windows env, for the follow up I ran it in the container itself, which is why the issue only came up in the follow up. |
|
Oops :) Sounds like #4478 will be useful for you too then. |
This is adapting the FS apis in `lib` for wasi (excluding git support). The compilation command for building this is: `cargo +nightly build --no-default-features --target wasm32-wasip1` * Nightly is needed for `std::os::wasi::fs::symlink_path`, if symlink support isn't needed then this can be non-nightly. * No default features is needed to not compile gitoxide, as that doesn't yet support wasi. This does not adapt the CLI, just lib.
Earthmark
force-pushed
the
earthmark/lib-wasi@origin
branch
from
13102f1
to
e5bc813
Compare
Thanks.
That sounds like a really interesting idea, although I think that just having the auto-snapshotting mechanism could be enough for you. Thank you for enabling the support for it. |
|
The ability to restructure changes is very useful as well. I'm happy to talk about it over discord if you're curious! |
It's really strange not putting a description of changes in this message.
This is my first set of JJ managed changes, I hope this works.