Validation strategy move #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add docstrings to classes and methods for better documentation - Update test_create_view_from_file_classification to reflect new error message - Add new tests for validation strategies: - test_training_strategy_has_validation_strategies - test_multiple_validation_strategies - test_default_validation_strategy_parameters - test_update_validation_strategy - test_remove_validation_strategy - test_different_models_different_validation_strategies - test_performance_metrics_associated_with_validation_strategies - Remove outdated tests related to validation strategies
- Remove validationStrategies from QSARModelSerializer - Update QSARModelInitSerializer to handle validationStrategies within trainingStrategy - Adjust create method to process validation strategies correctly These changes align the serializers with the new structure where validation strategies are part of the training strategy. This refactoring improves the consistency of the API and the internal representation of QSAR models.
…proved REST framework support.
Improve the robustness of the map creation process by implementing better error handling and logging in the Map model. Key changes include: - Add logging to capture and report errors - Refactor getChemSpaceJSDict for better error resilience: - Handle potential None values for property calculators - Use first() instead of get() for molecule queries - Implement try-except for activity aggregation - Enhance saveChemSpaceJSON with comprehensive error handling - Ensure ChemSpace dictionary generation is validated These changes address issues with map creation failures and improve the overall stability of the map generation process.
Update serializers in the maps app to enhance consistency and correctness. Key changes include: - Fix field inheritance in MappingStrategyInitSerializer - Simplify field definitions in MapSerializer Meta class - Refactor MapInitSerializer create method: - Improve handling of molsets and training strategy data - Ensure proper order of operations in instance creation - Enhance clarity and maintainability of the creation process These changes align the serializer behavior with the updated model structure and improve the overall robustness of the map creation process.
Improve the robustness of the createMap task by implementing comprehensive error handling and logging. Key changes include: - Add logging functionality for better error tracking - Implement try-except block to catch and log all exceptions - Include detailed error information and traceback in logs - Raise a new exception with a descriptive error message These changes will improve the ability to diagnose and resolve issues in the map creation process, enhancing the overall reliability of the system.
Enhance the MapBuilder class to provide better error handling and logging during the map building process. Key changes include: - Add logging functionality for improved error tracking - Implement try-except blocks in the build method to catch and log exceptions - Add validation to ensure points are generated successfully - Improve error handling for ChemSpaceJS JSON serialization - Maintain progress recording throughout the build process These changes will significantly improve the ability to diagnose and resolve issues during map creation, enhancing the overall reliability and maintainability of the mapping functionality.
Improve the robustness of map creation in the MapViewSet by implementing comprehensive error handling and logging. Key changes: - Override the create method in MapViewSet to catch exceptions - Add logging functionality for improved error tracking - Implement detailed error reporting in the response These changes will improve the ability to diagnose and resolve issues during map creation API calls, enhancing the overall reliability and user experience of the mapping functionality.
Enhance the error handling in the ModelViewSet's create method to provide more detailed information when model building fails. Key changes include: - Replace simple error representation with a more descriptive message - Include full traceback information in the error response - Maintain the HTTP 500 status code for server errors These improvements will facilitate easier debugging and provide more context to API consumers when model creation fails, enhancing the overall developer experience and system maintainability.
Improve the debugging capabilities of the MapTestCase by providing more detailed logging of the API response. Key changes include: - Add logging of the response status code - Include full response content in the test output - Replace JSON dump with more comprehensive response information These changes will facilitate easier troubleshooting of map creation issues during testing, improving the overall reliability and maintainability of the test suite.
Enhance the debugging capabilities of the EngstMaps MapTestCase by providing more detailed logging of the API response. Key changes: - Add logging of the response status code - Include full response content in the test output - Replace JSON dump with more comprehensive response information These improvements align the EngstMaps test suite with the main map tests, providing consistent and detailed output for easier troubleshooting and maintenance of the mapping functionality across different extensions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validation strategy moved to the training strategy.
Polymorphic parametrization of splits.