Allow custom bind addresses for share_instance_port and instance_control_port
#625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Default value for `share_instance_addr` should be `"127.0.0.1"` - Default value for `instance_control_addr` should be `"127.0.0.1"` - When setting `self.rpc_addr` replace the bind address of `"127.0.0.1"` with `self.instance_control_port` - Added support for new configuration parameters `shared_instance_address` and `instance_control_addr`
- Added default argument `bindaddr` with default value of `"127.0.0.1"` - We also now set `self.bind_ip` equal to `bindaddr`
|
Think I am basically done, will neaten up and double check |
|
Closing as not needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose ✍️
I like containerising things a lot and this could help with that as I want to run
lxmdin one container and have it connect over the container network to myrnsd