Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: native addons failure in stackblitz #139

Merged
merged 2 commits into from
Jul 11, 2024
Merged

fix: native addons failure in stackblitz #139

merged 2 commits into from
Jul 11, 2024

Conversation

rturnq
Copy link
Contributor

@rturnq rturnq commented Jul 11, 2024

Description

Stackblitz Web Containers do not support loading native addons. Our CJS to ESM transform code relies on @parcel/source-maps which loads native addons. This change makes loading this package conditional and on-demand to prevent runtime failures when CJS transformations are not needed.

Motivation and Context

Screenshots (if appropriate):

Checklist:

  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

Copy link

changeset-bot bot commented Jul 11, 2024

🦋 Changeset detected

Latest commit: 10f4ab8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@marko/vite Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rturnq rturnq merged commit 9e3b9dc into main Jul 11, 2024
7 checks passed
@rturnq rturnq deleted the fix-web-containers branch July 11, 2024 17:47
@github-actions github-actions bot mentioned this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant