feat: add fetch imp as third param in custom fetch #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }), | ||
| fetch: config.fetch | ||
| ? (...params: Parameters<typeof fetch>) => config.fetch!(...params, fetch) | ||
| : async (url, options) => { |
There was a problem hiding this comment.
@bill-min I think it'd be nice if the fetch passed into the override was the same as the one which is used by default (the async function below) so that it automatically resolves against the current origin, copies headers, etc. On the micro-frame side we're doing similar and just hoist up the common stuff https://github.com/marko-js/micro-frame/blob/main/src/node_modules/%40internal/micro-frame-component/node.marko#L10
There was a problem hiding this comment.
agree, just pushed another commit.
bill-min
force-pushed
the
feat-fetch-imp-as-param
branch
from
3678b73
to
c2ec8e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Screenshots (if appropriate):
Checklist: