Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<context> - Fix context when there are 2 top level components #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ccinelli
Copy link

@ccinelli ccinelli commented Nov 20, 2019

Scope

This connect 2 top level components through a channel.

Description

Fix #15, and #12 even if not by path.

Motivation and Context

Communication between top level components.

Checklist:

  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@jsf-clabot
Copy link

jsf-clabot commented Nov 20, 2019

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Nov 20, 2019

Codecov Report

Merging #16 (b7bf3c0) into master (3dbec36) will decrease coverage by 3.24%.
The diff coverage is 81.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
- Coverage   94.91%   91.66%   -3.25%     
==========================================
  Files           3        3              
  Lines          59       72      +13     
==========================================
+ Hits           56       66      +10     
- Misses          3        6       +3     
Impacted Files Coverage Δ
tags/context/src/helpers.js 87.50% <70.00%> (-12.50%) ⬇️
tags/context/src/components/context/transformer.js 93.33% <100.00%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dbec36...b7bf3c0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<context> - it does not work when there are multiple top level components
3 participants