Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getVisitorKeys throwing when called before parse #51

Merged

Conversation

AngusMorton
Copy link
Contributor

Closes: #50

When prettier-plugin-marko is used with prettier-plugin-tailwindcss getVisitorKeys throws an exception because currentCompiler is undefined... I have no idea why getVisitorKeys seems to be called before currentCompiler is populated.

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8f2ea07) 84.32% compared to head (e20f7d0) 84.34%.

Files Patch % Lines
src/index.ts 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
+ Coverage   84.32%   84.34%   +0.02%     
==========================================
  Files          11       11              
  Lines         606      607       +1     
  Branches      198      198              
==========================================
+ Hits          511      512       +1     
  Misses         59       59              
  Partials       36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DylanPiercey
Copy link
Contributor

DylanPiercey commented Dec 4, 2023

Looks great, appreciate the pr @AngusMorton!

@DylanPiercey DylanPiercey merged commit f1caf74 into marko-js:main Dec 4, 2023
4 of 5 checks passed
Copy link

github-actions bot commented Dec 4, 2023

🎉 This PR is included in version 3.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

currentCompiler is undefined in getVisitorKeys
2 participants