Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better ways to control src change and slot refreshing logic #28

Merged
merged 4 commits into from
Jan 8, 2024

Conversation

bill-min
Copy link
Contributor

@bill-min bill-min commented Jan 4, 2024

Description

For client-side src change and slot content refresh, there is currently no flexibility to control slot behavior. The PR adds feature to let slot change its client-side refresh logic.

  • no-refresh will disable slot refresh completely in client-side
  • Proper source name input change handling allows slot bind to different stream in client-side vs server-side

Motivation and Context

Screenshots (if appropriate):

Checklist:

  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4473bc8) 95.70% compared to head (d556763) 95.70%.

❗ Current head d556763 differs from pull request most recent head 477148d. Consider uploading reports for the commit 477148d to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #28   +/-   ##
=======================================
  Coverage   95.70%   95.70%           
=======================================
  Files           6        6           
  Lines         163      163           
  Branches       27       27           
=======================================
  Hits          156      156           
  Misses          2        2           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DylanPiercey DylanPiercey merged commit 2bb33a3 into marko-js:main Jan 8, 2024
4 checks passed
Copy link

github-actions bot commented Jan 8, 2024

🎉 This PR is included in version 1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants