Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE YET][ds-sam] adding current stake and stake delta columns #3

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ochaloup
Copy link
Contributor

@ochaloup ochaloup commented Aug 5, 2024

No description provided.

@ochaloup ochaloup requested a review from janlegner August 5, 2024 11:41
Copy link

cloudflare-workers-and-pages bot commented Aug 5, 2024

Deploying psr-dashboard with  Cloudflare Pages  Cloudflare Pages

Latest commit: 11b1f56
Status: ✅  Deploy successful!
Preview URL: https://4cb0fedc.psr-dashboard.pages.dev
Branch Preview URL: https://current-delta-stake-to-sam.psr-dashboard.pages.dev

View logs

@janlegner janlegner changed the title [ds-sam] adding current stake and stake delta columns [DO NOT MERGE YET][ds-sam] adding current stake and stake delta columns Aug 5, 2024
@janlegner
Copy link
Contributor

Do not merge yet

@ochaloup
Copy link
Contributor Author

ochaloup commented Aug 5, 2024

@janlegner I tried to do an update for the PR based on our conversation elsewhere. My thinking:

  • The title column should be a short text. I was considering maybe Delta or Diff to add but then the title is a bit long.
  • I believe a tooltip can provide the required info.
  • Naming is always a trouble and here it's not clear to me which direction it should be stated if the good proposition is when missing stake and bigger target will deliver it or if that's a different meaning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants