Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling filter #361

Open
wants to merge 73 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
73 commits
Select commit Hold shift + click to select a range
f666423
spelling: absence
jsoref Feb 20, 2023
dd54ea5
spelling: accordingly
jsoref Feb 20, 2023
ee58a1c
spelling: adjustments
jsoref Apr 7, 2023
ec3e505
spelling: alphanumeric
jsoref Feb 20, 2023
104fb72
spelling: although
jsoref Feb 20, 2023
c2267f6
spelling: ambiguous
jsoref Feb 20, 2023
24f12f8
spelling: autocommit
jsoref Feb 20, 2023
ad70588
spelling: because
jsoref Feb 20, 2023
80adff2
spelling: bookkeeping
jsoref Feb 20, 2023
233ecb0
spelling: buffer
jsoref Feb 20, 2023
7b139d9
spelling: byte
jsoref Feb 20, 2023
c4ee34e
spelling: cannot
jsoref Feb 22, 2024
259e673
spelling: capability
jsoref Feb 20, 2023
d1712ef
spelling: case-insensitive
jsoref Feb 22, 2024
520f0ad
spelling: case-sensitive
jsoref Feb 22, 2024
630d50e
spelling: character
jsoref Feb 20, 2023
cd59dfd
spelling: classifier
jsoref Feb 20, 2023
ea959ee
spelling: column
jsoref Feb 20, 2023
b56522a
spelling: columns
jsoref Feb 20, 2023
d52992d
spelling: committee
jsoref Feb 20, 2023
0277a61
spelling: comparison
jsoref Feb 20, 2023
76963f0
spelling: condition
jsoref Feb 20, 2023
cec6a3b
spelling: contiguous
jsoref Feb 20, 2023
a3856ef
spelling: database
jsoref Feb 20, 2023
1ec3d4c
spelling: databases
jsoref Feb 20, 2023
5a73285
spelling: degradation
jsoref Feb 20, 2023
41e3cb8
spelling: deleting
jsoref Feb 20, 2023
be1df4c
spelling: dilemma
jsoref Feb 20, 2023
c1220a1
spelling: entirely
jsoref Feb 20, 2023
22169c3
spelling: erroneous
jsoref Feb 20, 2023
85ebde3
spelling: evaluated
jsoref Apr 7, 2023
af904b5
spelling: excluding
jsoref Feb 20, 2023
d4af1c9
spelling: expected
jsoref Feb 20, 2023
314aa1f
spelling: explicitly
jsoref Feb 20, 2023
5991894
spelling: filename
jsoref Feb 20, 2023
386b18d
spelling: flushing
jsoref Feb 20, 2023
dfc5687
spelling: identifier
jsoref Feb 20, 2023
b0be2ed
spelling: inconsistent
jsoref Feb 20, 2023
8977dd0
spelling: initialized
jsoref Feb 20, 2023
162bb2e
spelling: insert
jsoref Feb 20, 2023
cca3b93
spelling: intensely
jsoref Feb 20, 2023
e399123
spelling: join
jsoref Feb 20, 2023
4b83b11
spelling: may
jsoref Feb 20, 2023
4aae9d7
spelling: needed
jsoref Feb 20, 2023
55d6257
spelling: nonexistent
jsoref Apr 7, 2023
c8cc0f4
spelling: object
jsoref Feb 20, 2023
cc2fa21
spelling: occurrence
jsoref Feb 20, 2023
f4bf32a
spelling: optimizer
jsoref Feb 20, 2023
9a362e0
spelling: param
jsoref Feb 20, 2023
ddadffe
spelling: payload
jsoref Feb 20, 2023
ebd6f50
spelling: phase
jsoref Feb 20, 2023
d15a185
spelling: practice
jsoref Feb 20, 2023
92c4498
spelling: privileges
jsoref Feb 20, 2023
f0af0a2
spelling: query
jsoref Feb 20, 2023
d799e02
spelling: really
jsoref Feb 20, 2023
79808af
spelling: reference
jsoref Feb 21, 2023
e94d081
spelling: referring
jsoref Feb 20, 2023
6a5e1d1
spelling: remaining
jsoref Feb 20, 2023
f10edd5
spelling: replication
jsoref Feb 20, 2023
4fbc26c
spelling: responded
jsoref Feb 20, 2023
b44c3a4
spelling: response
jsoref Feb 20, 2023
405eae2
spelling: returns
jsoref Feb 20, 2023
75ceb9f
spelling: rewritefilter
jsoref Feb 20, 2023
8ea9d6d
spelling: session
jsoref Feb 20, 2023
cca640e
spelling: slightly
jsoref Feb 20, 2023
874a91d
spelling: specified
jsoref Feb 20, 2023
f2ac1dd
spelling: specifies
jsoref Feb 21, 2023
0b745c0
spelling: statements
jsoref Feb 21, 2023
493e136
spelling: storage
jsoref Feb 20, 2023
fbf1083
spelling: template
jsoref Feb 20, 2023
6dd8e0c
spelling: transaction
jsoref Feb 20, 2023
103a04e
spelling: transmission
jsoref Feb 20, 2023
74af503
spelling: with
jsoref Feb 20, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions server/modules/filter/binlogfilter/binlogfiltersession.cc
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ bool BinlogFilterSession::routeQuery(GWBUF&& packet)
* Extract binlog replication header from event data
*
* @param event The replication event
* @param hdr Pointer to repliction header to fill
* @param hdr Pointer to replication header to fill
*/
static void extract_header(const uint8_t* event, REP_HEADER* hdr)
{
Expand Down Expand Up @@ -280,7 +280,7 @@ bool BinlogFilterSession::clientReply(GWBUF&& packet, const mxs::ReplyRoute& dow
* Member variable m_skip is set accordingly to db/table match.
*
* @param buffer The GWBUF with binlog event data
* @param hdr Reference to repliction event header
* @param hdr Reference to replication event header
* @return True id TABLE_MAP_EVENT contains
* db/table names to skip
*/
Expand Down Expand Up @@ -534,7 +534,7 @@ void BinlogFilterSession::replaceEvent(GWBUF& packet, const REP_HEADER& hdr)
uint32_t buf_len = packet.length();
uint32_t orig_event_type = 0;

// If size < BINLOG_EVENT_HDR_LEN + crc32 add rand_event to buff contiguos
// If size < BINLOG_EVENT_HDR_LEN + crc32 add rand_event to buff contiguous
mxb_assert(m_skip == true);

/**
Expand Down Expand Up @@ -656,7 +656,7 @@ void BinlogFilterSession::replaceEvent(GWBUF& packet, const REP_HEADER& hdr)
}

/**
* Extract the value of a specific columnr from a buffer
* Extract the value of a specific column from a buffer
* TODO: also in use in binlogrouter code, to be moved
* in a common place
*
Expand Down Expand Up @@ -761,9 +761,9 @@ void BinlogFilterSession::getReplicationChecksum(const GWBUF& packet)
* If received data len is MYSQL_PACKET_LENGTH_MAX
* then the beginning of a large event receiving is set.
*
* Also remaininf data are set
* Also remaining data are set
*
* @param len The binlog event paylod len
* @param len The binlog event payload len
* @param hdr The reference to binlog event header
*/
void BinlogFilterSession::handlePackets(uint32_t len, const REP_HEADER& hdr)
Expand All @@ -774,13 +774,13 @@ void BinlogFilterSession::handlePackets(uint32_t len, const REP_HEADER& hdr)
// Mark the beginning of a large event transmission
m_is_large = true;

// Set remaining data to receive accordingy to hdr.event_size
// Set remaining data to receive accordingly to hdr.event_size
m_large_left = hdr.event_size - (MYSQL_PACKET_LENGTH_MAX - 1);
}
}

/**
* Process received data size of a large event trasmission
* Process received data size of a large event transmission
* Incoming data don't carry the OK byte and event header
*
* This sets member variables
Expand Down Expand Up @@ -815,7 +815,7 @@ void BinlogFilterSession::handleEventData(uint32_t len)
* This function checks whether the statement should be replicated and whether the database/table name should
* be rewritten. If a rewrite takes place, the buffer can be reallocated.
*
* @param bufer Pointer to the buffer containing the event
* @param buffer Pointer to the buffer containing the event
* @param hdr The extracted replication header
* @param extra_len Extra static bytes that this event has (only EXECUTE_LOAD_QUERY_EVENT uses it)
*/
Expand Down
2 changes: 1 addition & 1 deletion server/modules/filter/binlogfilter/binlogfiltersession.hh
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ private:
// Reference to Filter instance
const BinlogFilter& m_filter;

// Skip database/table events in current trasaction
// Skip database/table events in current transaction
void skipDatabaseTable(const uint8_t* data);

// Get Replication Checksum from registration query
Expand Down
2 changes: 1 addition & 1 deletion server/modules/filter/cache/cache.hh
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ public:
const GWBUF& query);

/**
* Specifies whether a particular SessioCache should refresh the data.
* Specifies whether a particular SessionCache should refresh the data.
*
* @param key The hashed key for a query.
* @param pSession The session cache asking.
Expand Down
6 changes: 3 additions & 3 deletions server/modules/filter/cache/cache_storage_api.hh
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ public:
uint32_t max_count = 0;

/**
* The maximum size of the storage may may occupy, before it should evict
* The maximum size of the storage may occupy, before it should evict
* some items. A value of 0 means that there is no limit. The caller should
* specify 0, unless CACHE_STORAGE_CAP_MAX_SIZE is returned at initialization.
*/
Expand Down Expand Up @@ -345,10 +345,10 @@ public:
* @param key A key generated with get_key.
* @param flags Mask of cache_flags_t values.
* @param soft_ttl The soft TTL. A value of CACHE_USE_CONFIG_TTL (-1) indicates
* that the value specfied in the config, used in the creation,
* that the value specified in the config, used in the creation,
* should be used.
* @param hard_ttl The hard TTL. A value of CACHE_USE_CONFIG_TTL (-1) indicates
* that the value specfied in the config, used in the creation,
* that the value specified in the config, used in the creation,
* should be used.
* @param ppValue Pointer to variable that after a successful return will
* point to a GWBUF.
Expand Down
4 changes: 2 additions & 2 deletions server/modules/filter/cache/cacheconfig.cc
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ bool CacheConfig::post_configure(const std::map<std::string, mxs::ConfigParamete

if (configured)
{
make_config_adjustements();
make_config_adjustments();

// The check for m_pFilter here is for the unit tests that don't allocate a
// CacheFilter instance. This should be changed in some way so that the
Expand Down Expand Up @@ -390,7 +390,7 @@ bool CacheConfig::is_config_valid(const std::map<std::string, mxs::ConfigParamet
return valid;
}

void CacheConfig::make_config_adjustements()
void CacheConfig::make_config_adjustments()
{
if (this->soft_ttl > this->hard_ttl)
{
Expand Down
2 changes: 1 addition & 1 deletion server/modules/filter/cache/cacheconfig.hh
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ private:
bool post_configure(const std::map<std::string, mxs::ConfigParameters>& nested_params) override;

bool is_config_valid(const std::map<std::string, mxs::ConfigParameters>& nested_params);
void make_config_adjustements();
void make_config_adjustments();

private:
CacheFilter* m_pFilter;
Expand Down
6 changes: 3 additions & 3 deletions server/modules/filter/cache/cachefiltersession.cc
Original file line number Diff line number Diff line change
Expand Up @@ -264,8 +264,8 @@ StatementType get_statement_type(std::string_view sql)
if ((pKey == pKey_end) && ((pSql == pSql_end) || !isalpha(*pSql)))
{
// All is fine; either the statement only contain the keyword (so syntactically
// the statement is erroenous) or the keyword was followed by something else
// than an alhpanumeric character, e.g. whitespace.
// the statement is erroneous) or the keyword was followed by something else
// than an alphanumeric character, e.g. whitespace.
}
else
{
Expand Down Expand Up @@ -604,7 +604,7 @@ bool CacheFilterSession::clientReply(GWBUF&& data, const mxs::ReplyRoute& down,
if (m_invalidate_now)
{
// The response to either a COMMIT, or to UPDATE/DELETE/INSERT with
// autcommit being true.
// autocommit being true.

if (reply.is_complete())
{
Expand Down
2 changes: 1 addition & 1 deletion server/modules/filter/cache/cachefiltersession.hh
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ private:
char* m_zDefaultDb; /**< The default database. */
char* m_zUseDb; /**< Pending default database. Needs server response. */
bool m_refreshing; /**< Whether the session is updating a stale cache entry. */
bool m_is_read_only; /**< Whether the current trx has been read-only in pratice. */
bool m_is_read_only; /**< Whether the current trx has been read-only in practice. */
bool m_use; /**< Whether the cache should be used in this session. */
bool m_populate; /**< Whether the cache should be populated in this session. */
uint32_t m_soft_ttl; /**< The soft TTL used in the session. */
Expand Down
2 changes: 1 addition & 1 deletion server/modules/filter/cache/lrustorage.cc
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ class LRUStorage::LRUInvalidator : public LRUStorage::Invalidator
if (node_words.size() > 1)
{
// If there are multiple invalidation words associated with
// the node, then the node must be removed from the bookeeping
// the node, then the node must be removed from the bookkeeping
// of those words as well. Otherwise we have the following:
// SELECT * FROM t1 UNION SELECT * FROM t2 => Node stored to t1 and t2.
// DELETE * FROM t1 => Node removed from t1 and deleted
Expand Down
4 changes: 2 additions & 2 deletions server/modules/filter/cache/rules.cc
Original file line number Diff line number Diff line change
Expand Up @@ -507,7 +507,7 @@ bool CacheRuleCTD::matches_column(const mxs::Parser& parser,
if (databases.empty())
{
// If no databases have been mentioned, then we can assume that all
// tables and columns that are not explcitly qualified refer to the
// tables and columns that are not explicitly qualified refer to the
// default database.
if (zDefault_db)
{
Expand Down Expand Up @@ -782,7 +782,7 @@ bool CacheRuleRegex::matches_column(const mxs::Parser& parser,
if (databases.empty())
{
// If no databases have been mentioned, then we can assume that all
// tables and columns that are not explcitly qualified refer to the
// tables and columns that are not explicitly qualified refer to the
// default database.
if (zDefault_db)
{
Expand Down
8 changes: 4 additions & 4 deletions server/modules/filter/cache/rules.hh
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ protected:
}

const CacheConfig& m_config; // The cache config.
Attribute m_attribute; // What attribute is evalued.
Attribute m_attribute; // What attribute is evaluated.
Op m_op; // What operator is used.
std::string m_value; // The value from the rule file.
};
Expand Down Expand Up @@ -202,7 +202,7 @@ class CacheRuleQuery final : public CacheRuleSimple
{
public:
static CacheRuleQuery* create(const CacheConfig* pConfig, // The cache config.
Attribute attribute, // What attribute is evalued.
Attribute attribute, // What attribute is evaluated.
Op op, // What operator is used.
const char* zValue); // The value from the rule file.

Expand All @@ -224,7 +224,7 @@ public:
bool compare_n(const char* pValue, size_t length) const override final;

static CacheRuleRegex* create(const CacheConfig* pConfig, // The cache config.
Attribute attribute, // What attribute is evalued.
Attribute attribute, // What attribute is evaluated.
Op op, // What operator is used.
const char* zValue); // The value from the rule file.

Expand Down Expand Up @@ -253,7 +253,7 @@ class CacheRuleUser final : public CacheRule
{
public:
static CacheRuleUser* create(const CacheConfig* pConfig, // The cache config.
Attribute attribute, // What attribute is evalued.
Attribute attribute, // What attribute is evaluated.
Op op, // What operator is used.
const char* zValue); // The value from the rule file.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
//
// Note that we do not modify the set; deleting will not be performed other
// than in error situations (and at the time of this writing is considered to
// be removed entirelly) and it does not really matter if an non-existing key
// be removed entirely) and it does not really matter if an non-existing key
// is in the set.
//
// Invalidating
Expand Down Expand Up @@ -859,7 +859,7 @@ class RedisToken : public std::enable_shared_from_this<RedisToken>
}
else if (reply.is_status())
{
MXB_ERROR("Expected status OK as reponse to FLUSHALL, but received %s.", reply.str());
MXB_ERROR("Expected status OK as response to FLUSHALL, but received %s.", reply.str());
}
else
{
Expand Down Expand Up @@ -1231,7 +1231,7 @@ class RedisToken : public std::enable_shared_from_this<RedisToken>

// Does this work? Probably not in all cases; it appears that WATCH
// needs to be used to prevent problems caused by the fetching of the keys
// and the deleteing of the keys (and values) being done in separate
// and the deleting of the keys (and values) being done in separate
// transactions.

m_redis.check_for_io_error();
Expand Down
4 changes: 2 additions & 2 deletions server/modules/filter/cache/storagefactory.hh
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ public:
* provided.
*
* @param zName The name of the storage.
* @param config The storagfe configuration.
* @param config The storage configuration.
* @param parameters Storage specific parameters.
*
* @return A storage instance or NULL in case of errors.
Expand All @@ -98,7 +98,7 @@ public:
* accordingly.
*
* @param zName The name of the storage.
* @param config The storagfe configuration.
* @param config The storage configuration.
* @param parameters Storage specific parameters.
*
* @return A storage instance or NULL in case of errors.
Expand Down
Loading