Fix/remaining issues camera inside terrain

[chrneumann]

Launch Checklist

Add buffer so that camera doesn't sit directly on terrain. Prevent crashes when zoom is wrongly calculated.

• Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
• Briefly describe the changes in this PR.
• Link to related issues.
• Include before/after visuals or gifs if this PR includes visual changes.
• Write tests for all new functionality.
• Document any changes to public APIs.
• Post benchmark scores.
• Add an entry to CHANGELOG.md under the ## main section.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 87.78%. Comparing base (4d8a0f8) to head (9940ea5).
Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
src/geo/projection/mercator_transform.ts	55.55%	3 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4551      +/-   ##
==========================================
- Coverage   87.87%   87.78%   -0.09%     
==========================================
  Files         265      265              
  Lines       37577    37589      +12     
  Branches     2349     2352       +3     
==========================================
- Hits        33020    32999      -21     
- Misses       3518     3549      +31     
- Partials     1039     1041       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[HarelM]

@chrneumann where are we with this?

[chrneumann]

@chrneumann where are we with this?

Waiting for your reply, see the open code review.

[HarelM]

Hu?
Can you link to it?

[chrneumann]

Hu? Can you link to it?

https://github.com/maplibre/maplibre-gl-js/pull/4551/files/fe6191c166ac876ad07af08b277ec3e3d4538a9b#r1715277344

[HarelM]

Are you sure you have submitted your response?
This is what I see on my side:

[chrneumann]

Are you sure you have submitted your response?

Ok, sorry, I did not submit the review.

[HarelM]

Ok, looks good, can you check why the test is failing?

[chrneumann]

Ok, looks good, can you check why the test is failing?

Fixed that, a render test failed because of the readded buffer between terrain surface and camera.

[HarelM]

Should this PR still be in draft mode?

[HarelM]

Can you please add a changelog entry?

[chrneumann]

Done. New transform stuff also merged.

[HarelM]

Looking at the fact that you added code without a failing test can indicate that the added code in the transform class is not covered by tests?

[chrneumann]

Yes, the try/catch is not covered by a test. We talked about that before: #4551 (comment) Best would be to have more insights from someone who knows more about the recalculation code. Not sure, if you got a reply? But yeah, I could also try to crash it and find out which values lead to the crash and add a test with these values. But knowing why it crashes in the first place would be better.

[HarelM]

Did you push the commit? I still see that the code coverage is not getting to this catch block...

[chrneumann]

No, did you see the discussion at #4551 (comment) ?

[HarelM]

Yes, regardless of if the solution is an "if" or a try-catch, there's a need to add a test the reproduces this issue (I think a unit test is the right kind of test here, but I don't mind either way).
Once you have a scenario that can be reproduced we can better talk about the solution, I believe.