Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pbf from 3.3.0 to 4.0.1 #4378

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 9, 2024

Bumps pbf from 3.3.0 to 4.0.1.

Release notes

Sourced from pbf's releases.

v4.0.1

  • Avoid creating redundant zero-byte buffer when writing Pbf.
  • Fix Pbf constructor typings (mark buf as optional).

v4.0.0

  • ⚠️ Expose the library as a ES module, dropping CommonJS support.
  • ⚠️ Rewrite the codebase to use modern ES syntax (you can still transpile on your end to keep IE11 support).
  • ⚠️ Make code generation generate ESM modules by default, with CommonJS available through --legacy mode.
  • ⚠️ Overhaul code generation to write simpler code that's more compact and more susceptible to efficient minimization — instead of nested objects, the generated code has flat exports of read and write functions (see readme and test fixtures).
  • Add TypeScript type check & first-class typings via JSDoc comments.
  • Remove dependency on ieee754 package and use native DataView instead, which is faster and universally supported.
  • Modernize dev tools (use Rollup instead of Browserify for UMD builds, ESLint 9+; in addition to an earlier switch from Tap to native Node test runner and coverage and to GitHub Actions from Travis).
  • Fix writing of default oneof fields. #103 by @​farwayer
Commits
  • aca0c98 4.0.1
  • 2e67705 don't create redundant zero-byte buffer on write; mark buf as optional in typ...
  • 6dcee27 4.0.0
  • 288210e use DataView for reading and writing ints
  • 2995e6d Write default values to oneof fields in generated code (#135)
  • 1d724b1 add TypeScript type check & first-class typings via JSDoc comments
  • ff115a7 remove unnecessary destroy method
  • 24b6d10 improve test coverage for generated code
  • 85561da update readme
  • 719665e fix browser benchmark
  • Additional commits viewable in compare view
Maintainer changes

This version was pushed to npm by mapbox-npm-02, a new releaser for pbf since your current version.


Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jul 9, 2024
@github-actions github-actions bot enabled auto-merge (squash) July 9, 2024 08:17
Copy link
Collaborator

@louwers louwers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@types/pbf needs to be removed.

@HarelM
Copy link
Collaborator

HarelM commented Jul 11, 2024

I'll check if this solves the problem here.
Thanks for the tip.

@HarelM
Copy link
Collaborator

HarelM commented Jul 11, 2024

The types that I create for the vector tile package and those that it now generates are a bit off.
I've solved most of the issues in the following PR:
#4393

I'm waiting for the following PR to be merged to solve the rest of the issues:
mapbox/vector-tile-js#86

I've tested it locally, it can also be done with patch-package, but I'll wait a few days to see if it gets merged.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/pbf-4.0.1 branch from d7fbd63 to 98efd0d Compare July 25, 2024 08:30
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/pbf-4.0.1 branch from 98efd0d to 01017cc Compare July 25, 2024 08:30
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/pbf-4.0.1 branch from 01017cc to 666b02d Compare July 27, 2024 19:42
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/pbf-4.0.1 branch from 666b02d to 0c1e970 Compare August 5, 2024 09:10
Bumps [pbf](https://github.com/mapbox/pbf) from 3.3.0 to 4.0.1.
- [Release notes](https://github.com/mapbox/pbf/releases)
- [Commits](mapbox/pbf@v3.3.0...v4.0.1)

---
updated-dependencies:
- dependency-name: pbf
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/pbf-4.0.1 branch from 0c1e970 to 0fd8549 Compare August 5, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants