[Testing:TAGrading] Test markdown #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Per Shail from Submitty#7819, remove all uses of `key_to_click` on buttons, where this class is redundant and serves no purpose since the functionality that `key_to_click` implements is the default for buttons. --------- Co-authored-by: William Powe <[email protected]>
Fix Submitty#10590 ### What is the current behavior? There are currently no cookies for office hour notification sliders. So when TA leave/refresh the page or even remove/restore a student from the queue it will goes back to default. ### What is the new behavior? Now choices will be remembered. However the broswer wouldn't allow sound to be played without interaction. So if TA makes any action sound will be played as expected. Will make a separate issue about this. https://github.com/user-attachments/assets/34dd2915-a9c1-4789-859a-987acc82d733
### Please check if the PR fulfills these requirements: * [x] Tests for the changes have been added/updated (if possible) * [x] Documentation has been updated/added if relevant * [x] Screenshots are attached to Github PR if visual/UI changes were made ### What is the current behavior? When there is a version conflict for a component while grading, the header will contain the text " Please edit or ensure that comments from version <version> still apply." ### What is the new behavior? Changes it to "Version Conflict: Please edit or ensure that comments from version <version> still apply.", and adds a help link at the end. ### Screenshots #### Before:  #### After 
Submitty#10433 is related issue. In order to add link to submission in Rainbowgrades, we need to know the base_url of the server. However, generate grade summaries(ggs) does not load url info. ### What is the new behavior? With this change, ggs will create/store `base_url.json` in the reports directory. `({$SUBMITTY_DATA_DIR}/courses/{$SEMESTER}/{$COURSE}/reports)` ### To test: go to http://localhost:1511/courses/f24/sample/reports click Generate Grade Summaries -> go to terminal and `cd /var/local/submitty/courses/f24/sample/reports` see base_url.json -> see the content by `emacs base_url.json` check base_url is `http://localhost:1511/` <img width="864" alt="스크린샷 2024-07-23 오후 12 54 04" src="https://github.com/user-attachments/assets/a5ba7f5a-4ca4-42bc-b4fa-1473c5773ec7"> <img width="690" alt="스크린샷 2024-07-23 오후 12 53 50" src="https://github.com/user-attachments/assets/0639c19c-bec0-47a7-9eb7-c997db702751">
Vagrant currently attempts to forward to host port 7000 for SAML, which conflicts with the AirPlay receiver on macOS, which runs all the time by default. Since we don't want new developers to have to deal with port conflicts on their first vagrant up, this PR changes the default port to 7001.
### Please check if the PR fulfills these requirements: * [x] Tests for the changes have been added/updated (if possible) * [ ] Documentation has been updated/added if relevant * [x] Screenshots are attached to Github PR if visual/UI changes were made ### What is the current behavior? No Vue support ### What is the new behavior? This PR makes a new Vue project `site/vue` and adds the necessary infrastructure to load pages made in that project onto the main site, with a `renderVue()` PHP function (same syntax as `renderTwig()`). ### Other information? This isn't a breaking change, and documentation is still WIP.
### Please check if the PR fulfills these requirements: * [x] Tests for the changes have been added/updated (if possible) * [x] Documentation has been updated/added if relevant * [x] Screenshots are attached to Github PR if visual/UI changes were made ### What is the current behavior? Cypress and Jest tests are unlinted. ### What is the new behavior? This PR enables the recommended rules for Cypress and Jest tests, and applies them to the affected files.
manzil-infinity180
force-pushed
the
test_markdown
branch
from
f191ed4 to
a079c0d
Compare
manzil-infinity180
changed the base branch from
main
to
uncaught_syntax_error_notebook
manzil-infinity180
changed the base branch from
uncaught_syntax_error_notebook
to
main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements:
What is the current behavior?
What is the new behavior?
Other information?