Skip to content

Commit

Permalink
Merge branch 'main' of github.com:manufac-analytics/perry into sumitn…
Browse files Browse the repository at this point in the history
…egi7/#8-Migrate-vapor-pressure-data-bath2
  • Loading branch information
sumitnegi7 committed Jul 27, 2021
2 parents c836133 + b30da33 commit 715ffaa
Show file tree
Hide file tree
Showing 4 changed files with 45 additions and 0 deletions.
14 changes: 14 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -95,3 +95,17 @@ Per Palmer Group guidelines, [always use named exports.](https://github.com/palm
## Publishing to NPM

We recommend using [np](https://github.com/sindresorhus/np).

### Branching Workflows

#### Branch naming conventions

1. Use the following structure for naming any **feature branch**: `${username}/#${issue-number}-${some-title}`.
2. You can read more about the reasoning [here](https://deepsource.io/blog/git-branch-naming-conventions/).
3. The first portion of the branch name `${username}/...` is a "grouping token". It helps in clubing all the branches owned by a particular user.

#### Pushing a new feature

We follow the [Git Feature Branch Workflow](https://www.atlassian.com/git/tutorials/comparing-workflows/feature-branch-workflow) for pushing new features into the `master` branch.

---
18 changes: 18 additions & 0 deletions src/data/critical-constants-acentric-factor.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import { DIPPRCriticalConstantAndAcentricFactorProps } from '../interfaces/utils';

export const DIPPRCriticalConstantsAndAcentricFactorDictionary: Record<
string,
DIPPRCriticalConstantAndAcentricFactorProps
> = {
Acetaldehyde: {
name: 'Acetaldehyde',
formula: 'C2H4O',
CAS: '75-07-0',
molecularWeight: 44.05256,
criticalTemperature: 446,
criticalPressure: 5.57,
criticalVolume: 0.154,
criticalCompressibilityFactor: 0.221,
acentricFactor: 0.262493,
},
};
1 change: 1 addition & 0 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@ export * from './data/inchi-dictionary';
export * from './data/food-compounds';
export * from './data/density-constants';
export * from './data/thermal-conductivity-constants';
export * from './data/critical-constants-acentric-factor';
12 changes: 12 additions & 0 deletions src/interfaces/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -149,3 +149,15 @@ export interface DIPPRThermalConductivityProps {
thermalConductivityAtMinimumTemperature: number;
thermalConductivityAtMaximumTemperature: number;
}

export interface DIPPRCriticalConstantAndAcentricFactorProps {
name: string;
formula: string;
CAS: string;
molecularWeight: number;
criticalTemperature: number;
criticalPressure: number;
criticalVolume: number;
criticalCompressibilityFactor: number;
acentricFactor: number;
}

0 comments on commit 715ffaa

Please sign in to comment.