Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDBSCAN clustering method added for Bragg peaks inferred from DL model #17

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

HDBSCAN clustering method added for Bragg peaks inferred from DL model #17

wants to merge 6 commits into from

Conversation

warunawickramasingha
Copy link
Contributor

Added HDBSCAN clustering method as a post processing step for the Braggs peaks inferred from the DL model.

@warunawickramasingha warunawickramasingha changed the title HDBSCAN clustering method added HDBSCAN clustering method added for Bragg peaks inferred from DL model Nov 8, 2024
@warunawickramasingha warunawickramasingha mentioned this pull request Nov 8, 2024
Open
RichardWaiteSTFC
RichardWaiteSTFC requested changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@RichardWaiteSTFC RichardWaiteSTFC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, I think while the HDBSCAN is not performing as well as the QLab merging we keep the latter as the default.
Is there any reason to offer the user KMeans? Does it offer any advantage over the other methods?

RichardWaiteSTFC
RichardWaiteSTFC requested changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@RichardWaiteSTFC RichardWaiteSTFC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks, just a couple of minor doc updates!

diffraction/WISH/bragg-detect/cnn/README.md Show resolved Hide resolved
diffraction/WISH/bragg-detect/cnn/BraggDetectCNN.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichardWaiteSTFC RichardWaiteSTFC Awaiting requested review from RichardWaiteSTFC

Assignees

@RichardWaiteSTFC RichardWaiteSTFC

Labels
enhancement
Projects
ISIS Diffraction
Status: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@warunawickramasingha @RichardWaiteSTFC