Always enable loggers #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this and #50 still worth keeping around @martyngigg? |
Sorry I seemed to ignore this! I didn't get the notification for some reason. I think this change is worth making so that ERRORS show in the docker logs in production. I'll rebase and fix the conflicts. |
In production onl ERROR level messages are shown
martyngigg
force-pushed
the
django-logs-error
branch
from
682d306
to
df66a15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the loggers are only enabled for DEBUG so in production we miss all of the ERROR logs. This enables the console logger by default but switches the level between DEBUG/ERROR depending on the environment.
To Test
Check locally by introducing some
raise ValueError("Bad value")into a code path and check it is visible in thedocker-compose logs web