-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enter Time of Flight user properties in Spectrum Viewer #2159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeSullivan7
force-pushed
the
2158_Tof_user_properties
branch
from
April 15, 2024 13:19
5210976
to
eaf1028
Compare
MikeSullivan7
force-pushed
the
2158_Tof_user_properties
branch
from
April 22, 2024 08:23
eaf1028
to
5c0ecca
Compare
samtygier-stfc
requested changes
Apr 22, 2024
samtygier-stfc
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #2158
Description
A section has been added to the left hand side of the spectrum viewer which allows users to enter the Flight Path (meters) and the Time Delay (microseconds) used as these can change from experiment to experiment. The time delay can be used to artificially alter the neutron wavelength range. It was requested by IMAT that these option be "on show" rather than hidden away in a right click menu for example.
When the values in the spinboxes are changed, the associated attribute is altered in the
unit_conversion
object in the spectrum viewer model. This ensures that the converted data is recalculated properly when the ToF properties are changed and any alterations are contained in theUnitConversion
class.Testing
make check
Acceptance Criteria
Units
option should be disabled and the ToF properties options on the left should be greyed out\\isis\shares\IMAT\ExampleData\Brass\Corrected_Sample_PH20
), there should be a Bragg Edge around 4.3 angstroms.Documentation
Will add Release Note