Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to miniforge #1967

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Move to miniforge #1967

merged 3 commits into from
Nov 3, 2023

Conversation

samtygier-stfc
Copy link
Collaborator

@samtygier-stfc samtygier-stfc commented Nov 1, 2023

Issue

Closes #1949

Description

Previously we used Mambaforge to create a conda setup which contained the mamba command. Recently the conda-forge devs have unified their Miniforge and Mambaforge installers, so the are now identical.

This PR:

  • updates the docs to references Miniforge
  • use Miniforge in the github workflows
  • swap some old uses of the conda command to mamba (there are only a small number of cases where conda is still needed)

Testing & Acceptance Criteria

Check that the doc changes make sense

Check that the automated tests have successfully completed

Documentation

Not needed

@samtygier-stfc samtygier-stfc force-pushed the 1949-move-to-miniforge branch 3 times, most recently from 0e30ed7 to 0aba74a Compare November 1, 2023 16:53
@coveralls
Copy link

Coverage Status

coverage: 76.013%. remained the same when pulling fb72b2e on 1949-move-to-miniforge into 28db74e on main.

@samtygier-stfc samtygier-stfc marked this pull request as ready for review November 1, 2023 17:51
Copy link
Collaborator

@MikeSullivan7 MikeSullivan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs make sense and tests run successfully, mantidimaging runs great.

@samtygier-stfc samtygier-stfc added this pull request to the merge queue Nov 3, 2023
Merged via the queue into main with commit 86cffd5 Nov 3, 2023
8 checks passed
@samtygier-stfc samtygier-stfc deleted the 1949-move-to-miniforge branch November 3, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swtich from Mambaforge to Miniforge
3 participants