Revert screenshot paddding work around #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Padding screenshots so that a fixed image size is sent to applitools should no longer be needed.
Use the helper function instead of calling np.rand directly
For GUI tests we need determinist random output.
Get a deteministic random image
samtygier-stfc
force-pushed
the
revert_screenshot_padding
branch
from
3d295fd to
492ab84
Compare
|
If I make a deliberate change to a window size, it gets picked up now:
|
samtygier-stfc
force-pushed
the
revert_screenshot_padding
branch
from
1daed7d to
492ab84
Compare
DolicaAkelloEgwel
approved these changes
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Padding screenshots so that a fixed image size is sent to applitools
should no longer be needed.
Issue
Reverts change in #1004
Description
Remove padding
Also use a seed when generating a 'random' image, so that ignore regions are no longer needed.
Testing & Acceptance Criteria
Actions tests should pass.
Documentation
Not needed