Added check to match bins before conjoining workspaces.

[RabiyaF]

Description of work

Summary of work

Fixes #38090 .

Further detail of work

To test:

Manual Test

1. cd build
2. ninja
3. workbench -> to launch workbench
4. Run the following in the editor

ws1 = CreateSampleWorkspace(WorkspaceType="Histogram", NumBanks=2, BankPixelWidth=1, BinWidth=10, Xmax=50)
ws2 = CreateSampleWorkspace(WorkspaceType="Histogram", NumBanks=3, BankPixelWidth=1, BinWidth=10, Xmax=50)
ConjoinWorkspaces(InputWorkspace1=ws1, InputWorkspace2=ws2, CheckOverlapping=False, YAxisUnit="New unit", YAxisLabel="New label")

5. Verify that error is shown.

Run Test

1. cd build
2. ninja AllTests
3. Run the following in the terminal

ctest -R ConjoinWorkspacesTest

4. Verify that the test passes.

---

Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

• Is the code of an acceptable quality?
• Does the code conform to the coding standards?
• Are the unit tests small and test the class in isolation?
• If there is GUI work does it follow the GUI standards?
• If there are changes in the release notes then do they describe the changes appropriately?
• Do the release notes conform to the release notes guide?

Functional Tests

• Do changes function as described? Add comments below that describe the tests performed?
• Do the changes handle unexpected situations, e.g. bad input?
• Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

[jhaigh0]

A nice change, works without crash now.

You'll need to add a release note to docs/release/v6.12.0/Framework/Algorithms/Bugfixes/ in a file named after the issue number

[github-actions]

👋 Hi, @RabiyaF,

Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

[jhaigh0]

Approved pending CI checks

[cailafinn]

Just had a few code/documentation notes before merging:

[cailafinn]

Is there a reason that this file (and the associated .cpp) was changed (and resulting in having to change a large number of other files) rather than just dereferencing the pointer in ConjoinWorkspaces.cpp here?

[RabiyaF]

This update was mentioned by James on Slack discussions in ral-core for this PR. I think/presume this is a change that is being implemented in other refactors of the codebase and would need to be updated eventually. It was linked to work on this PR and seemed like an easy enough change to make. So, that is why these files were updated too.

[RabiyaF]

I have rebased and addressed the comments. The tests will pass. Just a heads up, tomorrow will be my last working day before the code freeze. As this issue was linked to the next release milestone, let me know if any other changes are required.