Repackage using newer tools #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterfpeterson
force-pushed
the
repackage
branch
from
5c60979
to
91d7d7d
Compare
|
It would be nice to reproduce this build https://github.com/mantidproject/livereduce/actions/runs/6963139456/workflow on a separate machine |
|
In an effort to eliminate ambiguity with the /usr/bin/rpmbuild command, rename the 'rpmbuild' shell script as 'rpmbuild.sh' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major rework of how the packaging metadata is described and the rpm spec file. The
setup.pyhas been removed and all information is specified in thepyproject.toml.The
rpmbuild.shscript has been changed to build asdistfirst rather than have git create the tarball. Creating thesdistis the only thing CI attempts.The specfile has been, essentially, rewritten. It no longer depends on python to install the package and uses the rpm macros for various commands (e.g.
%{__install}rather thaninstall).A thing to consider doing later is using the systemd scriptlets.
tip: to see what the rpm macros actually do, run
rpm --showrcandgrepthe results for things