Update split2
to v4.2.0; remove through2
and replace with Node stream.Transform
#6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit updates both
split2
andthrough2
to the latest version. Both dependencies were previously at version 2, now they are at version 4. From v4.0.0,split2
has droppedreadable-stream
pas a dependency, instead relying on Node's built-in streams. Apart from imposing a minimum version requirement of Node 12, this also meanssplit2
uses a different stream implementation tothrough2
(which usesreadable-stream@3
).The second commit removes
through2
and replaces it by extending theTransform
class from Node's built-instream
module. It's not a big change, but droppingreadable-stream
significantly lightens the project dependencies. The other way to go about it is passing the transform function to the class constructor (see the simplified construction method), which may be less efficient ifserialize
is called multiple times, but wouldn't hold the transform function in memory.