Skip to content

Commit

Permalink
Remove remaining mentions of NomicFoundation#638 in the code (NomicFo…
Browse files Browse the repository at this point in the history
…undation#1021)

Closes NomicFoundation#638 

The trivia item from NomicFoundation#638 is now separately tracked in NomicFoundation#1020.
  • Loading branch information
Xanewok authored Jun 22, 2024
1 parent 83cfe98 commit 0a2b0d4
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ pub enum TriviaParser {
Choice { parsers: Vec<TriviaParser> },

Optional { parser: Box<TriviaParser> },
// TODO(#638): Remove this, once we adapt the DSL v1 codegen model to the new v2 definition.
OneOrMore { parser: Box<TriviaParser> },
ZeroOrMore { parser: Box<TriviaParser> },

Expand Down
6 changes: 1 addition & 5 deletions crates/codegen/runtime/generator/src/parser/grammar.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,4 @@
//! Definitions of the [`GrammarElement`]s and the grammar itself ([`Grammar`]).

// TODO(#638): This is a leftover module from the original DSLv1 implementation.
// We should remove it and replace the grammar construction in the super `parser`
// module with the one from the new DSLv2 in the `constructor` module.
//! Definitions of the [`GrammarElement`]s and the grammar itself ([`Grammar`]) used by the parser generator.

use std::collections::HashMap;
use std::rc::Rc;
Expand Down
4 changes: 2 additions & 2 deletions crates/solidity/inputs/language/src/definition.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ codegen_language_macros::compile!(Language(
documentation_dir = "crates/solidity/inputs/language/docs",
binding_rules_file = "crates/solidity/inputs/language/bindings/rules.msgb",
root_item = SourceUnit,
// TODO(#638): For now this is on par with the DSL v1 definition to minimize the fallout.
// We should replace this with the new definition from #629.
// TODO(#1020): Define the end-of-file trivia explicitly rather than
// implicitly reusing the leading trivia in the generater parser code.
leading_trivia = OneOrMore(Choice([
Trivia(Whitespace),
Trivia(EndOfLine),
Expand Down

0 comments on commit 0a2b0d4

Please sign in to comment.