Fix postgres pool size #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
postgres pool_size and max_overflow were passed when using get_db_manager but not in the get_db dependency. Engine was created with the default values of 5 / 10, instead of 10 / 100 or the values from the config.
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #657 +/- ##
==========================================
+ Coverage 83.26% 83.31% +0.05%
==========================================
Files 78 78
Lines 6186 6205 +19
==========================================
+ Hits 5151 5170 +19
Misses 1035 1035
☔ View full report in Codecov by Sentry. |
wolfv
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When having many requests in parallel, we got issue with the database connection pool size:
According to the config, the default values should be 10 / 100. I found that postgres
pool_sizeandmax_overflowwere passed when usingget_db_managerbut not in theget_dbdependency.Engine was created with the default values of 5 / 10, instead of the values from the config.