Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration script for scoped API keys #655

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

beenje
Copy link
Contributor

@beenje beenje commented Aug 2, 2023

Add script to update package_versions uploader with API keys owner instead of the key anonymous user.

This is linked to #642 fixed in #647.
The script allows users to update existing databases automatically.

Update package_versions uploader with API keys owner instead of the key anonymous user.
This is linked to mamba-org#647
and allow to update existing databases.
SQL query needs to be wrapped in sqlalchemy.text.
Using raw string as been removed.
@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2023

Codecov Report

Patch coverage: 79.06% and project coverage change: -0.01% ⚠️

Comparison is base (2f819d4) 83.26% compared to head (1e54829) 83.26%.
Report is 2 commits behind head on main.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #655      +/-   ##
==========================================
- Coverage   83.26%   83.26%   -0.01%     
==========================================
  Files          78       79       +1     
  Lines        6186     6225      +39     
==========================================
+ Hits         5151     5183      +32     
- Misses       1035     1042       +7     
Files Changed Coverage Δ
.../3ba25f23fb7d_update_scoped_api_key_uploader_id.py 65.00% <65.00%> (ø)
quetz/main.py 86.46% <66.66%> (ø)
quetz/authorization.py 93.82% <95.00%> (+0.10%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wolfv wolfv added the bug Something isn't working label Aug 22, 2023
@wolfv
Copy link
Member

wolfv commented Aug 22, 2023

@AndreasAlbertQC do you have a minute to review this? :)

Copy link
Collaborator

@AndreasAlbertQC AndreasAlbertQC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @beenje ! Looks good to me

@AndreasAlbertQC AndreasAlbertQC merged commit f20db64 into mamba-org:main Aug 23, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants