-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composite ("cube") sources MVP #2012
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fined queries and arrow queries do it
…e backtracking case. Get filters and definitions on top of cube to pass through.
…he cube usage was determined (and thus when the query field def is generated)
…rors get logged twice
…er than in the middle
…es that work with previous composite usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the notion of a "composite" source to Malloy. This feature is experimental, and can be enabled with the
##! experimental.composite_sources
tag. Composite sources are used for handling cubed data.Syntax:
Note, this syntax is subject to change
source: x is composite(source_a, source_b, ...)
Semantics:
Known Limitations:
on
clauses of always joins which are not referenced elsewhere in the query will not be countedextend
blocks in subsequent stages will not be resolved, resulting in bad SQL generation (SQL will contain placeholder fields, and will not compile)SourceDef
s instead ofSourceRef
s currently—this means it is really easy to blow up the compiler withsource: a is ...; b is compose(a, a); c is compose(b, b); ...
Other Future Work:
accept
orexcept
in order to narrow down the fields. Ergonomically it might be better to have a syntax for manually specifying the fields and types.