Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add percent_rank presto function #1988

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Add percent_rank presto function #1988

merged 2 commits into from
Oct 31, 2024

Conversation

christopherswenson
Copy link
Contributor

No description provided.

@carlineng carlineng self-requested a review October 30, 2024 21:15
carlineng
carlineng approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@carlineng carlineng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I see there's a parameter specifically for needsWindowOrderBy. For partitioning, do all calculate functions allow partition_by clauses by default?

@christopherswenson
Copy link
Contributor Author

Yes, partition_by should be legal on all window functions

@christopherswenson christopherswenson merged commit 0b95c39 into main Oct 31, 2024
11 checks passed
@christopherswenson christopherswenson deleted the crs-percentage-rank branch October 31, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlineng carlineng carlineng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christopherswenson @carlineng